Add Iceberg support for name-based mapping schema #33315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
force-pushed
the
fix_ice_namemapping
branch
from
dcedd33 to
f5a0764
Compare
17 tasks
regadas
force-pushed
the
fix_ice_namemapping
branch
from
f5a0764 to
2b4ff68
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
cc @ahmedabu98; I'll rebase soon |
ahmedabu98
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Thanks for adding this, it might be worth calling out in CHANGES.MD
| @@ -88,6 +90,7 @@ public boolean advance() throws IOException { | |||
| // which are not null-safe. | |||
| @SuppressWarnings("nullness") | |||
| org.apache.iceberg.@NonNull Schema project = this.project; | |||
| String nameMapping = source.getTable().properties().get(TableProperties.DEFAULT_NAME_MAPPING); | |||
There was a problem hiding this comment.
nit
Suggested change
| String nameMapping = source.getTable().properties().get(TableProperties.DEFAULT_NAME_MAPPING); | |
| @Nullable String nameMapping = source.getTable().properties().get(TableProperties.DEFAULT_NAME_MAPPING); |
| String path = createParquetFile(avroSchema, avroRecords); | ||
| HadoopInputFile inputFile = HadoopInputFile.fromLocation(path, hadoopConf); | ||
|
|
||
| NameMapping defaultMapping = NameMapping.of(MappedField.of(1, "id"), MappedField.of(2, "data")); |
There was a problem hiding this comment.
can we include a nested field in this test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33314
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.